Bug fix for 2FA. #1882
Merged
Bug fix for 2FA. #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsuo
reviewed
May 22, 2024
| $expSeconds = $prefix == "" ? $this->dbSettings->getExpiringSeconds() : | ||
| ($prefix == "#" ? $this->dbSettings->getExpiringSeconds() : | ||
| ($prefix == "+" ? $this->dbSettings->getExpiringSeconds() : | ||
| ($prefix == "=" ? $this->dbSettings->getExpiringSeconds2FA() : |
There was a problem hiding this comment.
== による比較の部分、 === にすることは可能でしょうか？
PHP 8.0で比較演算子の扱いが変わっているので、可能なら === にしておくとよいと思います。
https://www.php.net/manual/ja/language.operators.comparison.php
より
警告
PHP 8.0.0 より前のバージョンでは、 文字列が数値または数値形式の文字列の場合、文字列は比較する前に数値に変換されていました。
|
Collectedly I fixed some bugs that were detected by unit test. |
matsuo
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.