Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: convert qodana config to new format #5404

Open
wants to merge 37 commits into
base: master
Choose a base branch
from
Open

Conversation

MartinWitt
Copy link
Collaborator

Need this for access to repo secrets.

@github-actions
Copy link
Contributor

Qodana Community for JVM

2064 new problems were found

Inspection name Severity Problems
Unchecked warning 🔶 Warning 991
Redundant type cast 🔶 Warning 175
Field may be 'final' 🔶 Warning 142
Nullability and data flow problems 🔶 Warning 136
Javadoc declaration problems 🔶 Warning 118
Deprecated API usage 🔶 Warning 97
Redundant type arguments 🔶 Warning 33
Type parameter hides visible type 🔶 Warning 31
Link specified as plain text 🔶 Warning 28
Unnecessarily escaped character 🔶 Warning 22
String concatenation as argument to 'StringBuilder.append()' call 🔶 Warning 20
'size() == 0' can be replaced with 'isEmpty()' 🔶 Warning 17
Constant values 🔶 Warning 13
Statement with empty body 🔶 Warning 13
Declaration has problems in Javadoc references 🔶 Warning 13
Unused assignment 🔶 Warning 12
Dangling Javadoc comment 🔶 Warning 11
Result of method call ignored 🔶 Warning 11
Redundant 'if' statement 🔶 Warning 11
@NotNull/@Nullable problems 🔶 Warning 10
Method is identical to its super method 🔶 Warning 10
Unnecessary call to 'toString()' 🔶 Warning 9
Suspicious collection method call 🔶 Warning 8
Access static member via instance reference 🔶 Warning 7
Minimum 'switch' branches 🔶 Warning 7
Unnecessary semicolon 🔶 Warning 7
Too weak variable type leads to unnecessary cast 🔶 Warning 6
Field can be local 🔶 Warning 6
Call to 'Arrays.asList()' with too few arguments 🔶 Warning 5
Catch block may ignore exception 🔶 Warning 5
Condition is covered by further condition 🔶 Warning 5
Mismatch between Javadoc and code 🔶 Warning 5
Redundant character escape 🔶 Warning 3
Redundant local variable 🔶 Warning 3
'equals()' method which does not check class of parameter 🔶 Warning 2
Non-serializable class with 'serialVersionUID' 🔶 Warning 2
Redundant array length check 🔶 Warning 2
Method does not call super method 🔶 Warning 2
Simplifiable conditional expression 🔶 Warning 2
Stream API call chain can be simplified 🔶 Warning 2
Redundant 'String' operation 🔶 Warning 2
Call to 'printStackTrace()' 🔶 Warning 2
Unnecessary 'return' statement 🔶 Warning 2
'hashCode()' called on array 🔶 Warning 1
Assignment used as condition 🔶 Warning 1
AutoCloseable used without 'try'-with-resources 🔶 Warning 1
Redundant 'Collection.addAll()' call 🔶 Warning 1
Suspicious 'Comparator.compare()' implementation 🔶 Warning 1
Conditional break inside loop 🔶 Warning 1
'equals()' between objects of inconvertible types 🔶 Warning 1
Subsequent steps can be fused into Stream API chain 🔶 Warning 1
Call to 'toString()' on array 🔶 Warning 1
Infinite recursion 🔶 Warning 1
Non-final field in 'enum' 🔶 Warning 1
Unnecessary 'null' check before method call 🔶 Warning 1
Redundant 'isInstance()' or 'cast()' call 🔶 Warning 1
Redundant escape in regex replacement string 🔶 Warning 1
Unnecessary non-capturing group 🔶 Warning 1
'serialVersionUID' field not declared 'private static final long' 🔶 Warning 1
Call to 'list.containsAll(collection)' may have poor performance 🔶 Warning 1
String concatenation in loop 🔶 Warning 1
Suspicious 'Collection.toArray()' call 🔶 Warning 1
'throw' inside 'finally' block 🔶 Warning 1
Unnecessary conversion to 'String' 🔶 Warning 1
Unnecessary label on 'continue' statement 🔶 Warning 1
Constant values ◽️ Notice 15
Method can be extracted ◽️ Notice 9
Duplicate branches in 'switch' ◽️ Notice 8
'if' statement with identical branches ◽️ Notice 2

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@MartinWitt
Copy link
Collaborator Author

MartinWitt commented Aug 28, 2023

Still need to disable the emote and the message. A fixall PR we can get daily would look like this #5405. We can also first start with a smaller cleanup PR.

@github-actions
Copy link
Contributor

Qodana for JVM

2120 new problems were found

Inspection name Severity Problems
Unchecked warning 🔶 Warning 991
Redundant type cast 🔶 Warning 175
Field may be 'final' 🔶 Warning 142
Nullability and data flow problems 🔶 Warning 136
Javadoc declaration problems 🔶 Warning 118
Deprecated API usage 🔶 Warning 97
Redundant type arguments 🔶 Warning 33
Type parameter hides visible type 🔶 Warning 31
Link specified as plain text 🔶 Warning 28
Unnecessarily escaped character 🔶 Warning 22
String concatenation as argument to 'StringBuilder.append()' call 🔶 Warning 20
'size() == 0' can be replaced with 'isEmpty()' 🔶 Warning 17
Constant values 🔶 Warning 13
Statement with empty body 🔶 Warning 13
Declaration has problems in Javadoc references 🔶 Warning 13
Unused assignment 🔶 Warning 12
Dangling Javadoc comment 🔶 Warning 11
Result of method call ignored 🔶 Warning 11
Redundant 'if' statement 🔶 Warning 11
Method is identical to its super method 🔶 Warning 10
Unnecessary call to 'toString()' 🔶 Warning 9
Suspicious collection method call 🔶 Warning 8
Access static member via instance reference 🔶 Warning 7
Minimum 'switch' branches 🔶 Warning 7
Unnecessary semicolon 🔶 Warning 7
Too weak variable type leads to unnecessary cast 🔶 Warning 6
Field can be local 🔶 Warning 6
Call to 'Arrays.asList()' with too few arguments 🔶 Warning 5
Catch block may ignore exception 🔶 Warning 5
Condition is covered by further condition 🔶 Warning 5
Mismatch between Javadoc and code 🔶 Warning 5
Redundant character escape 🔶 Warning 4
Redundant local variable 🔶 Warning 3
'equals()' method which does not check class of parameter 🔶 Warning 2
Non-serializable class with 'serialVersionUID' 🔶 Warning 2
Redundant array length check 🔶 Warning 2
Method does not call super method 🔶 Warning 2
Simplifiable conditional expression 🔶 Warning 2
Stream API call chain can be simplified 🔶 Warning 2
Redundant 'String' operation 🔶 Warning 2
Call to 'printStackTrace()' 🔶 Warning 2
Unnecessary 'return' statement 🔶 Warning 2
'hashCode()' called on array 🔶 Warning 1
Assignment used as condition 🔶 Warning 1
AutoCloseable used without 'try'-with-resources 🔶 Warning 1
Redundant 'Collection.addAll()' call 🔶 Warning 1
Suspicious 'Comparator.compare()' implementation 🔶 Warning 1
Conditional break inside loop 🔶 Warning 1
'equals()' between objects of inconvertible types 🔶 Warning 1
Subsequent steps can be fused into Stream API chain 🔶 Warning 1
Call to 'toString()' on array 🔶 Warning 1
Infinite recursion 🔶 Warning 1
Non-final field in 'enum' 🔶 Warning 1
Unnecessary 'null' check before method call 🔶 Warning 1
Redundant 'isInstance()' or 'cast()' call 🔶 Warning 1
Redundant escape in regex replacement string 🔶 Warning 1
Unnecessary non-capturing group 🔶 Warning 1
'serialVersionUID' field not declared 'private static final long' 🔶 Warning 1
Call to 'list.containsAll(collection)' may have poor performance 🔶 Warning 1
String concatenation in loop 🔶 Warning 1
Suspicious 'Collection.toArray()' call 🔶 Warning 1
'throw' inside 'finally' block 🔶 Warning 1
Unnecessary conversion to 'String' 🔶 Warning 1
Unnecessary label on 'continue' statement 🔶 Warning 1
Duplicated code fragment ◽️ Notice 65
Constant values ◽️ Notice 15
Method can be extracted ◽️ Notice 9
Duplicate branches in 'switch' ◽️ Notice 8
'if' statement with identical branches ◽️ Notice 2

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@MartinWitt
Copy link
Collaborator Author

The instance is now public you can have a look: https://qodana.cloud/projects/3KNVy/reports/RLk7X

Copy link
Collaborator

@I-Al-Istannen I-Al-Istannen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please disable spell checking, as I am not sure the 20k problems add much :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants