-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jupyterlab-ihaskell for 4.x #1426
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Came here from community forum, some super quick notes from reading code alone.
jupyterlab-ihaskell/src/index.ts
Outdated
name: 'ihaskell', | ||
mime: 'text/x-ihaskell', | ||
load: async () => { | ||
const hs = await Promise.resolve(import('@codemirror/legacy-modes/mode/haskell')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why wrap with Promise.resolve
?
const hs = await Promise.resolve(import('@codemirror/legacy-modes/mode/haskell')); | |
const hs = await import('@codemirror/legacy-modes/mode/haskell'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your code (which I based this off) had Promise.all
with multiple imports, but I only care about one import. I've moved to importing this at the top of my file but that doesn't seem to be making a difference.
Thanks for your help! I think I've made all the changes you suggested here but I'm still getting a blank screen and exactly the same error message. Any more ideas? |
9d210ef
to
a2c5617
Compare
a2c5617
to
de59f02
Compare
582aaa9
to
639f2b5
Compare
did you fix it @vaibhavsagar ? |
No, this PR doesn't work yet. |
how can i reproduce? |
You can run
on this branch to build a JupyterLab environment with IHaskell and |
639f2b5
to
fc1a56d
Compare
I need to reinstate the R modes and the |
No description provided.