Show metrics needing measurement in the UI. #8660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
fniessink
force-pushed
the
3134-show-whether-the-latest-measurement-of-metric-has-been-done-with-the-current-configuration-of-its-sources
branch
4 times, most recently
from
d56583b
to
c3bfa83
Compare
fniessink
force-pushed
the
3134-show-whether-the-latest-measurement-of-metric-has-been-done-with-the-current-configuration-of-its-sources
branch
from
c3bfa83
to
391ab84
Compare
fniessink
force-pushed
the
3134-show-whether-the-latest-measurement-of-metric-has-been-done-with-the-current-configuration-of-its-sources
branch
from
391ab84
to
c550cc3
Compare
fniessink
force-pushed
the
3134-show-whether-the-latest-measurement-of-metric-has-been-done-with-the-current-configuration-of-its-sources
branch
14 times, most recently
from
70e23bd
to
b1c5827
Compare
wkoot
reviewed
May 15, 2024
In the UI, show a metric as needing a measurement because the source parameters were recently changed. Implemented by: - In the collector: adding a hash of the source parameters to new measurements (and removing it from old measurements). - In the API-server: compare the hash of the latest measurement with the hash of the current configuration when adding recent measurements to a report and mark the metric as outdated. - In the UI: show metrics as needing a measurement if the last measurement is outdated. Closes #3134.
fniessink
force-pushed
the
3134-show-whether-the-latest-measurement-of-metric-has-been-done-with-the-current-configuration-of-its-sources
branch
from
b1c5827
to
c2666be
Compare
|
fniessink
deleted the
3134-show-whether-the-latest-measurement-of-metric-has-been-done-with-the-current-configuration-of-its-sources
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the UI, show a metric as needing a measurement because the source parameters were recently changed.
Implemented by:
Closes #3134.