Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR partially addresses LIU-368, which aims to enable proper persistence of data drops.
Currently, the
persist
andexpireAfterUse
flag are coupled together. This is orthogonal to the original behaviour, in which the expiry of the drop data should have no bearing on the persistence of the data (which would ensure it is copied elsewhere).This PR partially addresses this work by de-coupling the
expireAfterUse
behaviour from the persist behaviour.Solution
persist
check indlm.expireCompletedDrops
dlg.drop
so that if we only use the lifespan if we don't specifyexpireAfterUse
in the Drop arguments. Otherwise, we would setexpireAfterUse
toFalse
and then the lifespan would be set, which is the opposite of what we want.The current default behaviour exists:
Testing
expireAfterUse
toTrue
will lead to thefile.out
being removed from the workspace; setting it toFalse
leaves it present.Future work
The
'persist'
option has not been completely fulfilled. More work needs to be done to:persist
when there is no persistent file-store specified.