Lpar integration - installation on LPAR as nodes #241
Conversation
There was a problem hiding this comment.
Hi @sandisamp , thx for the PR. Following additonal comments:
- There is a description missing what support you are adding (lpar).
- You need to document what your are supporting (Classic vs. DPM, fcp device, etc).
- You have additional variables defined which needed to be explained and described.
- In your boot_LPAR task I do not see a interface name and you are supporting ipv4 only ... is this correct?
sandisamp
changed the title
There was a problem hiding this comment.
Hi @sandisamp Thx for the lpar. Pls add the description of the lpar to section 3 (Step 3: Set Variables (host_vars)) for the time being.
In addition pls add a section to the Readme.md (New features) and add your lpar support to it.
sandisamp
force-pushed
the
LPAR_integration
branch
2 times, most recently
from
df749d5
to
7462195
Compare
Signed-off-by: Sanidhya <sanidhya@Sanidhyas-MacBook-Pro.local>
sandisamp
force-pushed
the
LPAR_integration
branch
from
7462195
to
45110a6
Compare
| @@ -55,6 +55,7 @@ | |||
| ## 5 - Bastion | |||
| **Variable Name** | **Description** | **Example** | |||
| :--- | :--- | :--- | |||
| **env.bastion.installation_type** | Can be of type kvm or lpar. Some packages will be ignored for installation in case of lpar based installation. | kvm | |||
There was a problem hiding this comment.
Why is the installation_type variable defined under "env.bastion.installation_type" and not under "env.installation_type" ?
If enabled, bootstrap, control nodes and compute node will be installed in LPAR mode.
| include_role: | ||
| name: check_for_lpar_nodes | ||
| loop: | ||
| - bootstrap |
There was a problem hiding this comment.
Can we use a KVM guest as bootstrap, not an LPAR ?
| ansible.builtin.service: | ||
| name: NetworkManager | ||
| state: restarted | ||
| block: |
There was a problem hiding this comment.
This patch is not required anymore.
We use RHEL 9 as default OS.
| ansible.builtin.service: | ||
| name: NetworkManager | ||
| state: restarted | ||
| tags: dns, resolv |
There was a problem hiding this comment.
This patch is not required anymore.
We use RHEL 9 as default OS.
| @@ -39,7 +39,7 @@ | |||
| tags: lpar_check | |||
| stat: | |||
| path: "{{ inventory_dir }}/host_vars/{{ env.z.lpar1.hostname }}.yaml" | |||
| when: env.z.lpar1.hostname is defined | |||
| when: env.z.lpar1.create == True | |||
| @@ -155,10 +163,10 @@ | |||
| - client.crt | |||
| - client.key | |||
| - ta.key | |||
| when: env.setup_openvpn == True and env.z.high_availability == True | |||
| when: env.z.high_availability == True and env.bastion.installation_type|lower != "zvm" and env.bastion.installation_type|lower != "lpar" | |||
| roles: | |||
There was a problem hiding this comment.
why is" env.setup_openvpn == True" removed from the "when" check ?
| loop: | ||
| - bootstrap | ||
| - compute | ||
| - control |
There was a problem hiding this comment.
I do not see an error check ?
What happen if bootstrap install fails ?
Will the creation of compute nodes and control nodes continue ?
|
|
||
| - name: Undefine bootstrap. Expect ignored errors if bootstrap is already undefined. | ||
| tags: create_nodes, teardown_bootstrap | ||
| community.libvirt.virt: | ||
| name: "{{ env.cluster.nodes.bootstrap.vm_name }}" | ||
| command: undefine | ||
| ignore_errors: true | ||
| <<<<<<< HEAD |
There was a problem hiding this comment.
Bad patch !
Merge conflicts are not resolved !!!!!
|
|
||
| >>>>>>> 077c676 (Revert "Deleting entries related to Bootstrap in Haproxy post its del… (#255)) |
There was a problem hiding this comment.
Bad patch !!
Resolve merge conflicts correctly.
Create integration of LPAR into playbook - 6_create_nodes
Accordingly tasks and roles have been created.
Note: This PR is a work in progress. Created for initial reviews and not to make the review process too long. Will update detailed description when PR is ready.