Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add optional setup_file_server.yaml playbook #105

Draft
wants to merge 1,038 commits into
base: main
Choose a base branch
from
Draft

feat: Add optional setup_file_server.yaml playbook #105

wants to merge 1,038 commits into from

Conversation

jacobemery
Copy link
Collaborator

@jacobemery jacobemery commented Feb 23, 2023 •
edited

Related to issue 'Create optional playbook to setup file server' #103.

Add a playbook to automatically setup the file server. Based on feedback from users, the file server's setup causes a lot of confusion.

This playbook is not part of the official install path, but meant to be a helpful additional resource if needed. It would serve as an "executable documentation" for setting up the file server. Either this works as-is for some user's needs; or for those that it doesn't meet their needs, it at least lays out precisely what must be done.

Also adds accompanying documentation in prerequisites and run_the_playbooks pages.

@jacobemery
Changed name of storage group and root logvol
f9e4d71 
Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
@jacobemery
Resolving conflicts
770df5a 
Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
@jacobemery
Changed haproxy config to use FQDNs instead of IPs
c156436 
Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
@jacobemery
Moved wait for bootstrap complete role to create_nodes playbook
0cffb70 
Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
@jacobemery
Fixed workstation pkgs list format
e8d8de0 
Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
@jacobemery
Added tarballs of ansible galaxy collections in preparation for suppo…
7d8671a 
…rting disconnected installs.

Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
@jacobemery
Added one more to list of control vm_name list to match IP & hostname…
35d7d04 
… lists.
@jacobemery
Fixed variables file reference in playbooks
995382c 
Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
@jacobemery
Restructured GitHub Pages
8eb51a3 
Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
@jacobemery
Renamed playbooks to include numbers
5661d47 
Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
@jacobemery
Added comment to explain templating source
89934d3 
Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
@jacobemery
Removed teardown playbook
f01ad23 
Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
@jacobemery
Restructured GH Pages docs
3e0b1be 
Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
@jacobemery
Split set variables docs into two groups. Sectioned them out too.
f4e4c59 
Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
@jacobemery
Added packages and Ansible-Galaxy collection installs as pre-reqs.
b37f593 
Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
@jacobemery
Added detailed notes on each playbook.
faca8d0 
Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
@jacobemery
Removed reference to deprecated doc.
1a8b498 
Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
@jacobemery
Added numbers to playbooks' file names and setup to site.yaml playbook
46609db 
Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
@jacobemery
Include test playbook for people to double check variables/syntax
5b655fc 
Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
@jacobemery
Added multi-LPAR deployment variables
bfa4e89 
Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
@jacobemery
Added example KVM host host_vars files
b53a422 
Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
@jacobemery
Added conditionals to Ansible-Galaxy installs and checks on host_vars…
82038dc 
… setup.

Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
@jacobemery
Added support for multi-LPAR deployments
d02f3b7 
Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
@jacobemery
Added support for multi-LPAR deployments
69f8b83 
Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
@jacobemery
Added support for multi-LPAR deployments
6cce8ff 
Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
@jacobemery
Moved kickstart to use HTTP for ISO fetching as it's more reliable.
888fc85 
Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
@jacobemery
Added support for OpenVPN to enable cross-KVM host communication
172df51 
Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
@jacobemery
Moved wait_forbootstrap to create_nodes role to make sure bootstrappi…
39b7e10 
…ng was complete before moving to compute nodes

Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
@jacobemery
Moved wait_forbootstrap to create_nodes role to make sure bootstrappi…
1c29381 
…ng was complete before moving to compute nodes

Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
@jacobemery
Added roles from roberdebock to aid in setting up OpenVPN.
7c9f9dc 
Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
veera-damisetti and others added 11 commits August 10, 2023 09:30
@veera-damisetti
Enhancement: Added support for non root user to run hypershift playbo…
2f257f4 
…oks (IBM#190)

Added support for non root user to run hypershift playbooks

- Updated playbooks to allow users with sudo privileges to run the
hypershift playbooks.
- Added change to wait for MCE to be available after creating
AgentServiceConfig.

Updated documentation for the same

---------

Signed-off-by: damisetti.veerabhadrarao@ibm.com <damisetti.veerabhadrarao@ibm.com>
@veera-damisetti
Fix : Changed ssh key path - Hypershift (IBM#191)
730f3a7 
Changed ssh key path - Hypershift 

- Changed the path for ssh key on local host 
- Removed space while creating HCP which is causing issue while using
different basedomian

---------

Signed-off-by: damisetti.veerabhadrarao@ibm.com <damisetti.veerabhadrarao@ibm.com>
@smolin-de
feat: Detect automatically required RHCOS images for compute nodes (I…
2c6e6cf 
…BM#193)

This patch detects the required RHCOS images to install a compute node.

Signed-off-by: Klaus Smolin <smolin@de.ibm.com>
@veera-damisetti
Enhancement: Changed port for httpd configuration (IBM#194)
dcf34e8 
Changed port for httpd configuration

- Earlier we used port 443 and 8080 for httpd , but we have conflict
with port 443 while configuring HAProxy in later stages.
- So changed the port from 443 to 8443

---------

Signed-off-by: damisetti.veerabhadrarao@ibm.com <damisetti.veerabhadrarao@ibm.com>
@jacobemery
docs: add hypershift, remove CHANGELOG from mkdocs.yaml (IBM#195)
d62b453 
Update mkdocs.yaml file to include run-the-playbooks-for-hypershift.md,
and to remove CHANGELOG file as it has been replaced with
semantic-release.

Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
@jacobemery
docs: automate docs deployment on update (IBM#196)
7e7c497 
This adds a new workflow to GitHub Actions.

The action deploys an updated version of the documentation to GitHub
Pages.

It is triggered when changes are pushed to 'mkdocs.yaml' or anything
under the 'docs' folder on the 'main' branch.

This is necessary to make the docs up-to-date with our code, without
manual intervention.

Tested on my fork, although it required some tweaking there to adjust it
for testing purposes, so it might take some troubleshooting here in the
upstream.

Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
@AmadeusPodvratnik
Merge branch 'main' into add_file_server_playbook
5bd16b6
@AmadeusPodvratnik @veera-damisetti
@jacobemery @smolin-rh @smolin-de
fix: root user support - issue IBM#188 (IBM#197)
71ac238 
Fix for issue IBM#188 (root user suport). In addition set 0 for ip_forward
var as default because macvtap is default network setting. In addition
add var for subscription management.

---------

Signed-off-by: DAMISETTI-VEERABHADRARAO <damisetti.veerabhadrarao@ibm.com>
Signed-off-by: damisetti.veerabhadrarao@ibm.com <damisetti.veerabhadrarao@ibm.com>
Signed-off-by: Amadeuds Podvratnik <pod@de.ibm.com>
Signed-off-by: Klaus Smolin <smolin@de.ibm.com>
Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
Co-authored-by: veera-damisetti <damisetti.veerabhadrarao@ibm.com>
Co-authored-by: Jacob Emery <jacob.emery@ibm.com>
Co-authored-by: Klaus Smolin <119597269+smolin-rh@users.noreply.github.com>
Co-authored-by: Klaus Smolin <88041391+smolin-de@users.noreply.github.com>
@AmadeusPodvratnik
Merge branch 'main' into add_file_server_playbook
a33d339
@jacobemery
fix: pull updated gh-pages (IBM#200)
765b3c4 
Hotfix to IBM#196 that automates GitHub Pages deployments. Looks like the
workflow failed in error because it didn't have the most recent version
of the gh-pages branch. This PR will hopefully fix that issue.

Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
@AmadeusPodvratnik
Merge branch 'main' into add_file_server_playbook
cf3228b
@AmadeusPodvratnik
Copy link
Collaborator

@jacobemery I went through the changes and have some comments:

  • It's not clear where to install the FTP server. Basically a FTP server can be installed on KVM but than macvtap is not working. Using NAT, nodes have access to the KVM host. Make it sense to mention it.
  • Make it sense to have a simple index page user can query (e.g. curl command). E.g.:
Installation of FTP Server was successful!/body> - Why you removed the mount commands from documentation? I feel they are helpful and worth to be mentioned.

jacobemery and others added 10 commits September 15, 2023 10:52
@jacobemery
Fix YAML syntax error in GH Action
309acbb 
Signed-off-by: Jacob Emery jacob.emery@ibm.com
@AmadeusPodvratnik
Merge branch 'main' into add_file_server_playbook
c676183
@smolin-de
fix: Improve error handling (IBM#201)
aa03eca 
Improve error handling.

Signed-off-by: Klaus Smolin <smolin@de.ibm.com>
@smolin-de
fix: Import DNS role when defined and enabled (IBM#202)
66d7509 
Signed-off-by: Klaus Smolin <smolin@de.ibm.com>
@veera-damisetti
Fix: Added ClusterImageSet creation for nightly build image (IBM#204)
d181ac4 
- Added ClusterImageSet creation for nightly build image

Signed-off-by: damisetti.veerabhadrarao@ibm.com <damisetti.veerabhadrarao@ibm.com>
@smolin-de
feat: Add support to create aarch64 (arm64) compute node (IBM#203)
0682fbb 
Add support to create a aarch64 (arm64) compute node using
create_compute_node.yaml playbook.

Signed-off-by: Klaus Smolin <smolin@de.ibm.com>
@AmadeusPodvratnik
Merge branch 'main' into add_file_server_playbook
4fe5dd0
@jacobemery
fix: add manual option for docs deploy
254e868 
In order to test docs deployment GH action, add a manual deployment option.
@smolin-de
fix: Adjust wait time for bootstrap complete (IBM#208)
34dcd55 
Signed-off-by: Klaus Smolin <smolin@de.ibm.com>
@AmadeusPodvratnik
Merge branch 'main' into add_file_server_playbook
4166d08
AmadeusPodvratnik
AmadeusPodvratnik requested changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@AmadeusPodvratnik AmadeusPodvratnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @jacobemery for the PR. I tested it and have following comments:

  • due to the fact that a file_server entry in the hosts file is needed, this should be documented.
  • Make it sense to automate this step in case an user would like to have it "all together". E.g. if a user would like to have it all self contained than this step can be integrated into a more general setup playbook.
  • For macvtap network mode any other VM can be used if the LPAR has access to. Is this something you would like to mention?

smolin-de and others added 4 commits October 12, 2023 13:42
@smolin-de
fix: Temporary ignore some DNS checks (IBM#212)
5d0c254 
There are several open issues related to DNS. DNS setup needs to be
verified. We ignore some DNS check results for now, because of issue
166, 182.

Signed-off-by: Klaus Smolin <smolin@de.ibm.com>
@smolin-de
fix: Typo in when statement (IBM#215)
27d1202 
Signed-off-by: Klaus Smolin <smolin@de.ibm.com>
@smolin-de
fix: Increase timeout from 300 to 360 sec (IBM#218)
e13365a 
The creation of VM's requires more time on low performance systems.

Signed-off-by: Klaus Smolin <smolin@de.ibm.com>
@AmadeusPodvratnik
Merge branch 'main' into add_file_server_playbook
76e77a3
@jacobemery jacobemery marked this pull request as draft December 20, 2023 23:11
@jacobemery
Copy link
Collaborator Author

Needs rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmadeusPodvratnik AmadeusPodvratnik AmadeusPodvratnik requested changes

@smolin-de smolin-de Awaiting requested review from smolin-de

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jacobemery @AmadeusPodvratnik @ImgBotApp @silliman @smolin-de @routerhan @veera-damisetti