README 📝 add details for custom DNS provider(s) + renamed deprecated environment variable 'DNSx' to 'PIHOLE_DNS_x' #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed network
Added additional block/allow sources in FAQ
Use the spelling `Pi-hole` throughout document.
Minor name fixes
Revert "Minor name fixes"
Disable use-caps-for-id Disable num-thread specification Add so-rcvbuf
Which leads to Pi-hole incorrectly resolve pi.hole
Leads to 404
Verbosity Level to only log errors accoring to the documentation at https://unbound.docs.nlnetlabs.nl/en/latest/manpages/unbound.conf.html#term-verbosity-number is 0. The original conf logged operational info as well.
Fix ServerIP env for Pi-hole in compose
fix unbound's verbosity level & a typo
Minor typo in issue URL in README.md
|
@IAmStoxe , please review and merge. Thanks! |
IAmStoxe
requested changes
Apr 6, 2022
| @@ -65,8 +65,8 @@ services: | |||
| TZ: "America/Los_Angeles" | |||
| WEBPASSWORD: "" # Blank password - Can be whatever you want. | |||
| ServerIP: 10.2.0.100 # Internal IP of pihole | |||
| DNS1: 10.2.0.200 # Unbound IP | |||
| DNS2: 10.2.0.200 # If we don't specify two, it will auto pick google. | |||
| PIHOLE_DNS_1: 10.2.0.200 # Unbound IP | |||
There was a problem hiding this comment.
This should not over-write DNS as this is used by the container, not pihole.
There was a problem hiding this comment.
This is exactly my setup with https://github.com/pi-hole/docker-pi-hole and docker-compose and it works as expected:
etc-pihole/setupVars.conf
13:PIHOLE_DNS_1=45.90.28.39
14:PIHOLE_DNS_2=45.90.30.39
15:PIHOLE_DNS_3=2a07:a8c0::75:86b2
16:PIHOLE_DNS_4=2a07:a8c1::75:86b2
Please have a look at:
https://github.com/pi-hole/docker-pi-hole#optional-variables
https://github.com/pi-hole/docker-pi-hole#deprecated-environment-variables
…environment variable 'DNSx' to 'PIHOLE_DNS_x'
thomasmerz
force-pushed
the
readme_PIHOLE_DNS
branch
from
aa0d96f
to
86f3e7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add some more details for custom DNS provider(s) and adds some help how to choose the fastest and most reliable one (after you've chosen some that care for "independence and privacy"). One deprecated environment variable (
DNSx) is also renamed to the new variable (PIHOLE_DNS_x).