Making configurations for minimum and maximum total scrap value per level usable #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…evel usable The game, as at the moment of this commit, does not use either ``SelectableLevel.minTotalScrapValue`` and ``SelectableLevel.maxTotalScrapValue`` in the logic of spawning scrap in the level, thus rendering any changes of these values in the configurations of each level useless. In order to make them used, a transpiler patch is required in the spawn scrap method which influences the logic of spawning scrap with a notion of a maximum scrap value it can generate up to in the level. Fixes IAmBatby#82
|
Closing, Agree with intent but currently not interested in implementing a feature that has the potential to affect the base game in this way. |
|
@WhiteSpike, would you consider releasing this patch as a standalone mod, similar to the now outdated LethalLevelLoader Fixed? I just spent almost two hours configuring these options and am fairly disappointed to discover those configs do nothing, although understand why these options aren't currently a priority for LethalLevelLoader itself (although that admittedly makes me question why they exist). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The game, as at the moment of this commit, does not use either
SelectableLevel.minTotalScrapValueandSelectableLevel.maxTotalScrapValuein the logic of spawning scrap in the level, thus rendering any changes of these values in the configurations of each level useless.In order to make them used, a transpiler patch is required in the spawn scrap method which influences the logic of spawning scrap with a notion of a maximum scrap value it can generate up to in the level.
Fixes #82