Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The scrap value setting didn't work well. #82

Open
meBVH opened this issue Apr 28, 2024 · 1 comment
Open

The scrap value setting didn't work well. #82

meBVH opened this issue Apr 28, 2024 · 1 comment

Comments

@meBVH
Copy link

meBVH commented Apr 28, 2024

I set "Enable Content Configuration = true",but the Scrap Settings such that Minimum/Maximum Total Scrap Value didn't work right.
I set Maximum Total Scrap Value to 150, but it still had 400+ value scrap in game.
And I tried to use this mod in separate, but it still didn't work.

@WhiteSpike
Copy link

The problem with this issue is that the game itself doesn't use these variables (minTotalScrapValue and maxTotalScrapValue) when generating scrap in the moon (even though they are stored in the objects associated to each level which is then configurable through LLL).

To make these configurations actually take effect, there would have to be some sort of patch in the spawn scrap code in which it would make them be affected by these values without breaking anything.

WhiteSpike added a commit to WhiteSpike/LethalLevelLoader that referenced this issue May 12, 2024
…evel usable

The game, as at the moment of this commit, does not use either ``SelectableLevel.minTotalScrapValue`` and ``SelectableLevel.maxTotalScrapValue`` in the logic of spawning scrap in the level, thus rendering any changes of these values in the configurations of each level useless.

In order to make them used, a transpiler patch is required in the spawn scrap method which influences the logic of spawning scrap with a notion of a maximum scrap value it can generate up to in the level.

Fixes IAmBatby#82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants