Add shift keymap #297
Open
Add shift keymap #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of remapping the keys with `Terminal::remap`, this introduces a shift keymap based on the US layout. Most notably, one can now type '_', which is commonly included in test names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using underscores in test names is pretty common.
Now that sweb has tab completion, you can select tests with underscores in their name without having to type them.
Which lead to groups being confused why the tortillas test runner cannot run their tests.
So I thought it would be good to make underscores typeable by default.
Instead of remapping the keys with
Terminal::remap, this introduces a shift map based on the US layout.So other characters like
:"|<>?+are also typeable.If this is not desirable, I would propose to just add underscores to the remap function like this.
Idk about the rpi2 and rpi3 implementations, their E0 map is weird, so I did not even touch that.
This will break shift for them.