user backtrace fix #291
Open
user backtrace fix #291
+29
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changed it from no backtrace prints to a warning. |
dgruss
reviewed
Mar 24, 2023
| if (thread->user_registers_->rbp % sizeof(pointer)) | ||
| { | ||
| debug(BACKTRACE, "stack not aligned. this could cause serious problems\n"); | ||
| return 0; |
There was a problem hiding this comment.
is this return intentionally here?
There was a problem hiding this comment.
left it in by mistake.
already removed it
|
Made a small mistake there. with correct 16 byte alignment the old code was fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checkAddressValid panics when given a non-canonical address due to the new assert in resolveMapping.
A user could trigger this by crashing with a non-canonical address in rbp.
Add an extra check in checkAddressValid since it should never assert.
An incorrectly aligned user-space stack could make the user backtrace function read from an incorrect page in the identity mapping. This can lead to a crash due to a read from non-existing physical memory.