Fix exception thrown by, and suppress output from, the Speak function #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the creation of the `SAPI.SpVoice` object above selection of the voice, as there's currently an error thrown when running this function due to the object not yet existing.
The `Speak` method returns a number which is used when "speaking" asynchronously. As a user, the number is meaningless and via this function it will always be `1`. This assigns the output to `null` so that there is no output from the function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stops the Speak function from throwing an exception when it tries to enumerate voices on the
SAPI.SpVoiceobject before it has been created.Further, the
.Speakmethod used in this function outputs a number that's used in apps to associate queued async streams with events. As a user though... it means nothing and as the function doesn't set the async flag, it always returns1anyway.