Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECH] Remove Nile and Amazon Integration #884

Merged
merged 9 commits into from
May 28, 2024
Merged

Conversation

flavioislima
Copy link
Contributor

@flavioislima flavioislima commented May 13, 2024

This is a long one but it is basically code removal so testing is appreciated.

To test

  • Just be sure that all information for Amazon store is gone from the App in places like: Login Screen, Library filters, logs, etc.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima flavioislima self-assigned this May 13, 2024
@flavioislima flavioislima added the PR: Ready-For-Review PR is ready to be reviewed by peers label May 13, 2024
@BrettCleary
Copy link
Collaborator

Appreciate the clean up!

I was only able to find a few remaining references to nile in the package.json
image

Copy link
Collaborator

@BrettCleary BrettCleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

red is a great color! less to maintain! woot! 💃

@red-game-dev
Copy link
Contributor

red is a great color! less to maintain! woot! 💃

Ofc is good color, is part of my name! 😆

@flavioislima
Copy link
Contributor Author

Appreciate the clean up!

I was only able to find a few remaining references to nile in the package.json image

good catch!

@flavioislima flavioislima added PR: Ready-For-Test PR is ready to be tested by a QA and removed PR: Ready-For-Review PR is ready to be reviewed by peers labels May 20, 2024
@nyghtstalker
Copy link

I am unable to locate any Amazon content or related options - before and after the removal.

image

image

@eliobricenov eliobricenov removed their request for review May 28, 2024 15:16
@flavioislima flavioislima merged commit 5ac2f77 into main May 28, 2024
16 checks passed
@flavioislima flavioislima deleted the tech/remove_amazon branch May 28, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Ready-For-Test PR is ready to be tested by a QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants