[Fix] EBUSY during download cancel #783
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliobricenov
reviewed
Mar 5, 2024
| @@ -84,8 +84,8 @@ export const handleDMQueueInformation = ( | |||
| export const cancelDownload = (removeDownloaded: boolean) => | |||
| ipcRenderer.send('cancelDownload', removeDownloaded) | |||
|
|
|||
| export const cancelExtraction = (appName: string) => | |||
| ipcRenderer.send('cancelExtraction', appName) | |||
| export const cancelExtraction = (appName: string, removeDownloaded: boolean) => | |||
There was a problem hiding this comment.
I think we should pass an object instead of a flag.
canceExtraction = ({ appName, removeDownloaded }: {appName: string; removeDownloaded: boolean }) => {...}| @@ -0,0 +1,42 @@ | |||
| import fs from 'fs' | |||
|
|
|||
| export function deleteFolderRecursive(path: string) { | |||
There was a problem hiding this comment.
why not using rmSync with recursive flag?
fs.rmSync(dir, { recursive: true, force: true });There was a problem hiding this comment.
doesn't work unfortunately. only works if the folder is already empty
tried all the solutions from https://stackoverflow.com/questions/18052762/remove-directory-which-is-not-empty and this is the only one that worked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the directory when canceling an in progress download was being called twice and failing with EBUSY. Selecting to keep the files would still attempt to delete them.
TBD how to handle cancel during extraction with Yes/No to keeping download files.