Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement temporary bans #391

Merged
merged 6 commits into from
Apr 10, 2024
Merged

Implement temporary bans #391

merged 6 commits into from
Apr 10, 2024

Conversation

NoComment1105
Copy link
Member

This PR adds temporary bans, as suggested in #389

@NoComment1105 NoComment1105 added the PRT: new-feature This PR adds a new feature(s) label Apr 2, 2024
@NoComment1105 NoComment1105 linked an issue Apr 2, 2024 that may be closed by this pull request
Temp bans #389
Closed
@NoComment1105
Merge branch 'develop' into issue-389
7acd80c 
# Conflicts:
#	src/main/kotlin/org/hyacinthbots/lilybot/extensions/moderation/ModerationCommands.kt
tempest15
tempest15 requested changes Apr 4, 2024
View reviewed changes
Copy link
Member

@tempest15 tempest15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the ban remove command should just be incorporated into the unban command.

Also, soft-ban feels redundant now. We could definitely remove it, maybe replace it by adding an optional message deletion to kick or a default duration for this command.

@NoComment1105
Merge branch 'develop' into issue-389
be1510d 
# Conflicts:
#	docs/commands.md
#	src/main/kotlin/org/hyacinthbots/lilybot/database/migrations/main/mainV10.kt
@NoComment1105
Apply review comments
0ad01b3 
- Remove temp-ban remove, incorporate into unban
- Remove soft-ban, incorporate into main ban command
tempest15
tempest15 approved these changes Apr 8, 2024
View reviewed changes
docs/commands.md Outdated Show resolved Hide resolved
@NoComment1105 NoComment1105 merged commit a61c526 into develop Apr 10, 2024
2 checks passed
@NoComment1105 NoComment1105 deleted the issue-389 branch April 10, 2024 12:22
@NoComment1105 NoComment1105 mentioned this pull request Apr 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tempest15 tempest15 tempest15 approved these changes

Assignees
No one assigned
Labels
PRT: new-feature This PR adds a new feature(s)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Temp bans
2 participants
@NoComment1105 @tempest15