This repository has been archived by the owner on Feb 29, 2024. It is now read-only.
Solve Type Error in scroll_request method
#982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following error occurs in `scroll_request` method:
```
Traceback (most recent call last):
File "C:\Users\SohangChopra\AppData\Local\Programs\Python\Python311\Lib\site-packages\labelImg\labelImg.py", line 965, in scroll_request
bar.setValue(bar.value() + bar.singleStep() * units)
TypeError: setValue(self, a0: int): argument 1 has unexpected type 'float'
```
This is because ` units = - delta / (8 * 15)` is a `float`, so `bar.value() + bar.singleStep() * units` is also coerced to a `float`. The solution is to use `//` (integer division) instead of `/`.
|
@tzutalin Please review this pull request, and let me know if there are any issues. Thanks in advance 🙂 |
|
@tzutalin Did you have a chance to review this PR yet? |
1 similar comment
|
@tzutalin Did you have a chance to review this PR yet? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following error occurs in
scroll_requestmethod:This is because
units = - delta / (8 * 15)is afloat, sobar.value() + bar.singleStep() * unitsis also coerced to afloat. The solution is to use//(integer division) instead of/.