Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to CircleCI #121

Merged
merged 20 commits into from Nov 19, 2019
Merged

Migrate to CircleCI #121

merged 20 commits into from Nov 19, 2019

Conversation

AdamGleave
Copy link
Member

@AdamGleave AdamGleave commented Nov 19, 2019

  • Add CircleCI Config
  • Delete .travis.yml config
  • Add Dockerfile and build image, with MuJoCo support
  • Parallelize tests using pytest-shard.

Should run significantly faster now.

No longer testing 3.6 so I've dropped support from that in setup.py. I don't feel strongly about this so we could also just test in 3.6 instead of 3.7. However I feel OK with only officially supporting latest release (3.8) plus last one.

@codecov
Copy link

codecov bot commented Nov 19, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@43e23fa). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #121   +/-   ##
=========================================
  Coverage          ?   84.35%           
=========================================
  Files             ?       58           
  Lines             ?     3932           
  Branches          ?        0           
=========================================
  Hits              ?     3317           
  Misses            ?      615           
  Partials          ?        0
Impacted Files Coverage Δ
src/imitation/scripts/parallel.py 93.54% <100%> (ø)
src/imitation/scripts/config/parallel.py 63.46% <100%> (ø)
src/imitation/testing/envs.py 100% <100%> (ø)
tests/test_scripts.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43e23fa...78181da. Read the comment docs.

Copy link
Member

@shwang shwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch. Here's a few nits and some questions about how the new system works:

Dockerfile Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
.gitignore Show resolved Hide resolved
.circleci/config.yml Show resolved Hide resolved
.circleci/config.yml Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
@shwang
Copy link
Member

shwang commented Nov 19, 2019

Wow, 4min only for tests! (Used to be almost 20min per job)

Copy link
Member

@shwang shwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shwang
Copy link
Member

shwang commented Nov 19, 2019

updated README instructions to match setup.py (supports python 3.8 and 3.7)

@AdamGleave AdamGleave merged commit b3f66d2 into master Nov 19, 2019
@AdamGleave AdamGleave deleted the circleci branch November 19, 2019 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants