-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to CircleCI #121
Migrate to CircleCI #121
Conversation
Codecov Report
@@ Coverage Diff @@
## master #121 +/- ##
=========================================
Coverage ? 84.35%
=========================================
Files ? 58
Lines ? 3932
Branches ? 0
=========================================
Hits ? 3317
Misses ? 615
Partials ? 0
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch. Here's a few nits and some questions about how the new system works:
Wow, 4min only for tests! (Used to be almost 20min per job) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
updated README instructions to match setup.py (supports python 3.8 and 3.7) |
pytest-shard
.Should run significantly faster now.
No longer testing 3.6 so I've dropped support from that in
setup.py
. I don't feel strongly about this so we could also just test in 3.6 instead of 3.7. However I feel OK with only officially supporting latest release (3.8) plus last one.