Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated deps and resolve finally with a given config #51

Merged
merged 3 commits into from Feb 21, 2017

Conversation

capaj
Copy link
Collaborator

@capaj capaj commented Feb 21, 2017

why resolve with a config? To get at least some context to the finally handler as to which fetch request finished.

Maybe we could add the url there as a second param?

@gillchristian
Copy link
Member

Nice work @capaj, I like the idea.

@ndelvalle
Copy link
Member

I like this @capaj 👍🏼. I Also like your suggestion of passing the formated url as second argument, because we don't have the base url in the config (In case they are using one).
Can you remove the build bundle please? We should add that to the readme in the contribution section, sry about that.

@capaj
Copy link
Collaborator Author

capaj commented Feb 21, 2017

@ndelvalle added the url as well, also edited readme.md. By removing the bundle, you probably meant putting it in .gitignore right?

@ndelvalle ndelvalle merged commit d638179 into Huemul:master Feb 21, 2017
@ndelvalle
Copy link
Member

Thanks @capaj I'll fix the lint warning that bithound is throwing, add a bit more to the README and publish a new version later today. Thanks again for the contribution 🙂

@capaj
Copy link
Collaborator Author

capaj commented Feb 22, 2017

@ndelvalle could we get a new release? We're using it in production and we're using yarn. We need the latest changes deployed, so I tried using a url to my git repo. No, that does not work well with yarn, had to create this bug: yarnpkg/yarn#2743

So then I tried publishing trae namespaced on @capaj/trae ahead of you. Guess what-that does work but it fails with flow-typed that we also use: flow-typed/flow-typed#671

So until you release, we have to hack it by including the minified trae file in our repo. Which sucks.

@gillchristian
Copy link
Member

@capaj sorry for the inconvenience

I will publish the new version in a few minutes.

@gillchristian
Copy link
Member

trae 1.1.2 published 🎉

@capaj

@capaj
Copy link
Collaborator Author

capaj commented Feb 22, 2017

@gillchristian thx! you're da best

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants