Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to TypeScript for better types #1

Closed
wants to merge 9 commits into from

Conversation

Howard86
Copy link
Owner

Changes

// currently
import hydrate from 'next-mdx-remote/hydrate'
import renderToString from 'next-mdx-remote/render-to-string'

// if we export all from `index.ts`
import {  hydrate, renderToString } from 'next-mdx-remote'

@06kellyjac
Copy link

Is this meant to be a PR into your fork's master or into hashicorp/next-mdx-remote's master?

@Howard86
Copy link
Owner Author

@06kellyjac
Oh, this is meant to be my own master. I am still testing the npm package myself and have found some weird bugs after my own rework. By the way, thank you for your comments about @babel/types! It does save me some time research what's behind the scene.

@Howard86
Copy link
Owner Author

next-mdx-remote has been greatly improved since, also shipped with types.
closed for now

@Howard86 Howard86 closed this Feb 25, 2021
@Howard86 Howard86 deleted the feature/migrate-to-ts branch February 25, 2021 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants