Use create date over expiry on remember 2fa cookie #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a remember 2fa cookie is issued expiring in 30 days and the server is updated with a new value for `remember_otp_session_for_seconds`, the cookie will still be valid for 30 days, as the final date was set on it. To get around that, timestamp the cookie and compare that to the current setting on the server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a remember 2fa cookie is issued expiring in 30 days and the server is
updated with a new value for
remember_otp_session_for_seconds, thecookie will still be valid for 30 days, as the final date was set on it.
To get around that, timestamp the cookie and compare that to the current
setting on the server.