Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subscriber/raid notifications, capture exception upon emote parsing failure. #35

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

DorCoMaNdO
Copy link

Changes are untested.

Capture exception upon emote parsing failure.

This commit is untested.
@DorCoMaNdO
Copy link
Author

@Hotrian any chance you could test this and release an update so that the people who still use this program could have a drag&drop fix?

@Hotrian
Copy link
Owner

Hotrian commented Dec 28, 2019

Sure, if I get a chance I will give it a look, though I can't say for sure when I will have some time to test it out

@DorCoMaNdO
Copy link
Author

Thank you.

I believe I know why the emote parsing fails, the modified emote ids appear to be appending a string to the id, despite normal emotes only ever using an integer, changing let emoteId = int.Parse(emote.Substring(0, emoteSplit)) to let emoteId = emote.Substring(0, emoteSplit) and changing the EmoteId variable of EmoteKey from int to string should do the trick.

@Hotrian
Copy link
Owner

Hotrian commented Jun 26, 2020

Hey sorry it has taken me so long to go over this one. I still won't be able to test this for a couple of months as I am in the process of moving, and my VR setup is thus down currently. I should be able to test this in a month or two and integrate it along with changing the emote Id to being string compatible as some of the newer emotes have a string format instead of an integer format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants