Skip to content

Commit

Permalink
refactor(ts-lint): remove rules that are handled by prettier and dont…
Browse files Browse the repository at this point in the history
… use glob in package.json

we dont need to use --type-check and with that also no need for using globs within npm scripts
  • Loading branch information
Hotell committed Jun 17, 2017
1 parent 6c0f4b2 commit f3fd9e1
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 20 deletions.
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -25,7 +25,7 @@
"test:watch": "npm test -- --watch",
"test:coverage": "npm test -- --coverage",
"test:only-changed": "npm test -- --bail --onlyChanged",
"ts:lint": "tslint --project tsconfig.json --type-check \"src/**/*.{ts,tsx}\"",
"ts:lint": "tslint --project tsconfig.json",
"ts:lint:fix": "npm run ts:lint -- --fix",
"ts:format:base": "prettier --single-quote --print-width 120 --trailing-comma es5 --no-semi --parser typescript {src,__{tests,mocks}__}/**/*.{ts,tsx}",
"ts:format": "npm run ts:format:base -- --list-different",
Expand Down
23 changes: 4 additions & 19 deletions tslint.json
Expand Up @@ -7,30 +7,17 @@
"rules": {
// tslint-react rules
"jsx-no-lambda": true,
"jsx-alignment": true,
"jsx-no-string-ref": true,
"jsx-self-close": true,
"jsx-no-multiline-js": false,
"jsx-curly-spacing": false,
"jsx-wrap-multiline": false,
"jsx-boolean-value": [true,"never"],
"jsx-boolean-value": [
true,
"never"
],
// core ts-lint rules
"arrow-parens": true,
"await-promise": true,
"no-unused-variable": true,
"forin": true,
"indent": [
true,
"spaces"
],
"linebreak-style": [
true,
"LF"
],
"max-line-length": [
true,
120
],
"no-bitwise": true,
"no-console": [
true,
Expand All @@ -52,7 +39,6 @@
"no-require-imports": true,
"no-duplicate-super": true,
"no-boolean-literal-compare": true,
"space-before-function-paren": [true, "never"],
"quotemark": [
true,
"single",
Expand All @@ -67,7 +53,6 @@
true,
"check-function-in-method"
],
"import-spacing": true,
"ordered-imports": [
true
],
Expand Down

0 comments on commit f3fd9e1

Please sign in to comment.