Clean up warnings #217
Open
Clean up warnings #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced usage of deprecated ref cell operators := and ! I didn't change any ref cells to mutables, except in BuilderTests.fs where a mutable was obviously ok.
Renamed some parameters in Stream.fs that didn't match their equivalents in Stream.fsi. We could instead disable warning 3218, but then if someone has trouble debugging they might not understand why.
Fixed nuget warning NU5048. The PackageIconUrl property is deprecated. - Added Hopac's existing package icon to the repository - Added PackageIcon property to the fsproj, and included & packed the icon png
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made some minor changes to get rid of warnings.
I did have to commit the 20KB package icon to resolve nuget warning NU5048.
Edit: the following warning appears intermittently for me in VS Code / Ionide.
It doesn't seem like low-hanging fruit so I'll leave it alone for now.