Use SDK version 6.0.101 #216
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the SDK version in global.json to 6.0.101
Using AppVeyor's Visual Studio 2022 image should allow us to build with .NET SDK 6.0.101
|
After building my main codebase with .NET SDK 6, I'm getting TypeLoadExceptions when the runtime goes to load certain F# generic types. Everything works fine if I build with .NET SDK 5. Possibly related to dotnet/sdk#22258 I want to isolate this issue and make sure it's not going to affect Hopac. (Just to be clear, I don't have any direct evidence that it does actually affect Hopac.) |
|
I've isolated the issue I was having with .NET SDK 6, and reported dotnet/fsharp#12645. (I believe the TypeLoadExceptions I was seeing earlier were caused by crashes due to stack overflow.) So building Hopac releases with .NET SDK 6 should be ok, but I'll leave this PR as draft until I hear more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the .NET SDK version in global.json to 6.0.101. This just allows the latest SDK to be used during builds (which was the simplest way to build FsiRefGen submodule on .NET 6).
Actual target framework is still netstandard2.0 in case anyone is using Hopac on .NET Framework or other older platforms.
Edit: I needed to change the AppVeyor image to Visual Studio 2022 for SDK 6.0.101 support.