Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

flutter 0.3.1 (new formula) #27395

Closed
wants to merge 1 commit into from
Closed

Conversation

briankung
Copy link

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Regarding the tests:

$ brew audit --strict
Missing libraries:
  /System/Library/Frameworks/MobileCoreServices.framework/MobileCoreServices
  /System/Library/Frameworks/OpenGLES.framework/OpenGLES
  /System/Library/Frameworks/UIKit.framework/UIKit
flutter:
  * Stable version URLs should not contain beta
  * fully scope test system calls e.g. system "#{bin}/flutter"
  * Non-executables were installed to "/usr/local/opt/flutter/bin"
    The offending files are:
      /usr/local/opt/flutter/bin/cache
            /usr/local/opt/flutter/bin/internal
            /usr/local/opt/flutter/bin/flutter.bat
  * flutter has broken dynamic library links:
      
Error: 4 problems in 1 formula

So clearly everything's fine 馃憤 馃檮 :shipit:

However flutter --version works fine, as does flutter create foo. I haven't yet bothered to step through flutter doctor and address all the issues, but I thought I'd stop for a bit and submit a PR to get feedback both here from Homebrew and potentially from the folks at flutter/flutter#14050

Feedback welcome!

@xster
Copy link

xster commented May 2, 2018

Thanks for making the PR! This is awesome.

I haven't fully gone through the https://www.rubydoc.info/github/Homebrew/brew/master/Formula docs but off of the top of my head, we should

  1. Auto-bundle the iOS dependencies (that we kinda list at https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/ios/ios_workflow.dart)
  2. Since flutter can also self update, we should make sure various combination usages don't break such as updating flutter using flutter and then not downgrading with brew upgrade if the formula isn't updated etc.

# and Flutter writes to bin/cache, particularly .lockfile, so reenable
# write permissions on the cache folder
chmod_R "u+w", prefix/"bin/cache"
# See https://github.com/Homebrew/homebrew-core/issues/17098#issuecomment-386031418
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a valid alternative to the double upgrading conflict. We can actually prompt the user back to use brew upgrade if the directory is not writable from the flutter tool. Feel free to file a feature request for us for that handling.

We also want users to be able to modify packages/flutter/lib and modify the framework dart code.

@briankung
Copy link
Author

Closing as per Flutter team's preference to implement as a brew tap: flutter/flutter#14050 (comment)

@briankung briankung closed this May 3, 2018
@lock lock bot added the outdated PR was locked due to age label Jun 2, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants