Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pmix 5.0.2 #166807

Merged
merged 8 commits into from Mar 29, 2024
Merged

pmix 5.0.2 #166807

merged 8 commits into from Mar 29, 2024

Conversation

BrewTestBot
Copy link
Member

Created by brew bump

Created with brew bump-formula-pr.

@github-actions github-actions bot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Mar 21, 2024
@chenrui333 chenrui333 added the test failure CI fails while running the test-do block label Mar 21, 2024
@chenrui333
Copy link
Member 

brew test --retry --verbose boost-mpi
brew test --retry --verbose cp2k
brew test --retry --verbose mfem
brew test --retry --verbose mpi4py
brew test --retry --verbose open-mpi
brew test --retry --verbose opencoarrays
brew test --retry --verbose otf2

@github-actions github-actions bot added the CI-linux-self-hosted Build on Linux self-hosted runner label Mar 21, 2024
@fxcoudert
Copy link
Member

fxcoudert commented Mar 21, 2024 •
edited 

  ld: warning: -commons use_dylibs is no longer supported, using error treatment instead
  ld: common symbol '_mpi_fortran_argv_null_' from '/private/tmp/cclH6ubZ.o' conflicts with definition from dylib '_mpi_fortran_argv_null_' from '/opt/homebrew/Cellar/open-mpi/5.0.2_1/lib/libmpi_usempi_ignore_tkr.40.dylib'

Apple linker regression in Xcode 15.3
Reported as FB13194355

Also reported to OpenMPI: open-mpi/ompi#12427

@fxcoudert fxcoudert mentioned this pull request Mar 21, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Mar 23, 2024
@chenrui333 chenrui333 added in progress Stale bot should stay away and removed stale No recent activity labels Mar 24, 2024
@fxcoudert fxcoudert mentioned this pull request Mar 27, 2024
Closed
@fxcoudert fxcoudert added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Mar 27, 2024
Bo98
Bo98 reviewed Mar 27, 2024
View reviewed changes
Formula/o/open-mpi.rb

# Work around asm incompatibility with new linker (FB13194320)
# https://github.com/open-mpi/ompi/issues/11935
ENV.append "LDFLAGS", "-Wl,-ld_classic" if DevelopmentTools.clang_build_version >= 1500
Copy link
Member

@Bo98 Bo98 Mar 27, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it needs to be FCFLAGS instead (or in addition?)

https://github.com/open-mpi/ompi/blob/b5328be6ff3f1ae92dc94c922766d1f192bbd3af/config/ompi_setup_fc.m4#L241-L243

Copy link
Member

@Bo98 Bo98 Mar 27, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reckon open-mpi wrapper stuff doesn't read from the environment though so might need to hack the configure file to insert.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically: whatever is required to make it appear in share/openmpi/mpifort-wrapper-data.txt. I edited that file locally and it seems to work.

@fxcoudert
Copy link
Member

I tried FCFLAGS and wrapper_extra_ldflags but neither is working. But… according to https://docs.open-mpi.org/en/v5.0.x/installing-open-mpi/configure-cli-options/misc.html#install-wrapper-flags-label this should do the trick: --with-wrapper-ldflags=

@fxcoudert fxcoudert removed in progress Stale bot should stay away test failure CI fails while running the test-do block labels Mar 27, 2024
@fxcoudert fxcoudert added the ready to merge PR can be merged once CI is green label Mar 28, 2024
@chenrui333 chenrui333 requested a review from Bo98 March 28, 2024 21:22
Bo98
Bo98 approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions GitHub Actions
Copy link
Contributor

:shipit: @fxcoudert has requested bottles to be published to this PR.

@github-actions GitHub Actions
Copy link
Contributor

⚠️ @fxcoudert bottle publish failed.

@fxcoudert fxcoudert mentioned this pull request Mar 29, 2024
Merged
@fxcoudert
Copy link
Member

vineyard is conflicting with #166008

@github-actions GitHub Actions
Copy link
Contributor

:shipit: @ZhongRuoyu has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Mar 29, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Mar 29, 2024
Merged via the queue into master with commit 5168b9d Mar 29, 2024
14 checks passed
@BrewTestBot BrewTestBot deleted the bump-pmix-5.0.2 branch March 29, 2024 14:46
chenrui333
chenrui333 reviewed Mar 30, 2024
View reviewed changes
Formula/o/open-mpi.rb
@@ -38,6 +39,10 @@ def install
if OS.mac?
# Otherwise libmpi_usempi_ignore_tkr gets built as a static library
ENV["MACOSX_DEPLOYMENT_TARGET"] = MacOS.version

# Work around asm incompatibility with new linker (FB13194320)
# https://github.com/open-mpi/ompi/issues/11935
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this issue reference seems wrong?

#167579

@chenrui333 chenrui333 mentioned this pull request Mar 30, 2024
Merged
6 tasks
chenrui333 added a commit that referenced this pull request Mar 30, 2024
@chenrui333
open-mpi: update upstream issue ref
556d8c5 
relates to #166807

Signed-off-by: Rui Chen <rui@chenrui.dev>
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 29, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

@Bo98 Bo98 Bo98 approved these changes

@fxcoudert fxcoudert fxcoudert approved these changes

@github-actions github-actions[bot] github-actions approved these changes

Assignees
No one assigned
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-linux-self-hosted Build on Linux self-hosted runner CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@BrewTestBot @chenrui333 @fxcoudert @Bo98 @ZhongRuoyu