ko: update repo location #121332
Closed
ko: update repo location #121332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did the ldflag to set the version also change? |
|
AFAIK, no need to update the ldflag, PTAL @imjasonh |
imjasonh
reviewed
Jan 23, 2023
developer-guy
force-pushed
the
feature/fix-ko-repository-url
branch
2 times, most recently
from
8070b52
to
a472b45
Compare
|
@developer-guy let's follow the commit style in here, https://docs.brew.sh/Formula-Cookbook#commit |
chenrui333
added
CI-syntax-only
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
developer-guy
force-pushed
the
feature/fix-ko-repository-url
branch
from
a472b45
to
428d4cf
Compare
|
it should be okay right now, thanks @chenrui333 |
chenrui333
approved these changes
Jan 23, 2023
|
🤖 A scheduled task has triggered a merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Batuhan Apaydın batuhan.apaydin@trendyol.com
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?ko has been moved out to its new repository named ko-build1, this PR aims to replace the ko's repository URL with the most recent one.
/cc @mattmoor @imjasonh
Footnotes
https://github.com/ko-build/ko/issues/791 ↩