Skip to content
This repository has been archived by the owner on May 16, 2024. It is now read-only.

Document installation via Brewfile #9359

Closed
wants to merge 1 commit into from

Conversation

jasonkarns
Copy link

@jasonkarns jasonkarns commented May 8, 2024

Font installation has changed a few times (particularly from caskroom tap) and googling for how to install fonts via Brewfile surfaces a few conflicting approaches.

I think it would be beneficial if taps documented how they were to be used within a Brewfile. This is especially helpful for homebrew's first-party taps, to remove any potential confusion that there may perhaps be a font "inconsolata" mechanism or similar; given that brew, cask, mas, whalebrew and vscode are all first-class Brewfile methods. It also eliminates any confusion about whether the font- prefix should be present in the Brewfile, given that there are other prefixes in the homebrew ecosystem that can conventionally be omitted in certain cases. Thus, an explicit example seems worthwhile.


(not a cask PR, so the following is not applicable)

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@bevanjkay
Copy link
Member

Thanks for suggestion this. I think this is more suitable to be added to the homebrew-bundle readme.

It's also worth noting that the plan is to migrate everything in this repo to the homebrew-cask repo, and this repo would no longer be tapped.

@jasonkarns
Copy link
Author

I think this is more suitable to be added to the homebrew-bundle readme.

Maybe? It would be fine for homebrew-bundle to exhaustively document installation of any formulae for core taps. However, it's not feasible to document an example for all taps. Which is why I think this kind of documentation belongs in the taps themselves (whether core or 3rd party). Indeed, when I was confused about how to install this, the first place I looked is the tap, not brew-bundle. (I wouldn't expect brew-bundle to have an example for arbitrary taps, whereas a tap could reasonably document the Brewfile installation alternative.)

For this reason, I suggested (and it has landed) the tap template including a brewfile example: Homebrew/brew#17256

the plan is to migrate everything

If this tap is not long for this world, we certainly don't need to bother modifying the readme. But if there's a chance this merge doesn't take place soon-ish (your call on what "soon" means :D ), I would think it's still valuable to bring the tap into consistency with the tap template for uniformity if nothing else?

@bevanjkay
Copy link
Member

Thanks @jasonkarns for your understanding. The hope is that this repo will be migrated within the next week or two.

@bevanjkay bevanjkay closed this May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip documentation Issue regarding documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants