Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question about initial constraints #13

Open
zhang123huang opened this issue Mar 18, 2021 · 1 comment
Open

question about initial constraints #13

zhang123huang opened this issue Mar 18, 2021 · 1 comment

Comments

@zhang123huang
Copy link

zhang123huang commented Mar 18, 2021

Thank you for sharing the code. I have a doubt about constraints on initial variable in problem P*(x). In equation (21) of reference [1] (p.222), the initial constraints are expressed as "x belongs to x0+Z ", where x0 is the decision variable of optimal control problem P*(x), and x is the known current state. While in the file "TubeModelPredictiveControl.m", line 41-42, the constraints are described as "Xinit = x_init + obj.sys.Z", where "x_init" is the known current state x, and "Xinit" is the constraint boundary added to the problem with the form Ax<=b to restrict initial decision variable. I think that the code in line 41 implies "x0 belongs to x+Z", which is not consistent with the original constraint "x belongs to x0+Z ". What's your opinion?

@HiroIshida
Copy link
Owner

@zhang123huang Thank you for your pointing out! You are right. I made mistake. I'll fix it later, or it would be also really nice if you make a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants