Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 2014_10_12_000000_create_users_table.php #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Tahir-K
Copy link

@Tahir-K Tahir-K commented Mar 4, 2022

Updated default users table in the database section.

  1. Added 'country' as a required field.
  2. Added 'full name' as a required field.
  3. Added 'mobile' as a required field.

@haithamalnaeb
Copy link
Contributor

haithamalnaeb commented Mar 4, 2022

@Tahir-K

Thanks for PR, great start,

Please notice that we didn't start programming yet, we only started API spec sheet design,
After that will start DB design,
then we can implements db updates

I will keep this PR for later, in the meantime, you can contribute to API (/apis.yaml)
but since you already submit your PR, I'll review it for you so you can improve it and resubmit it again:

  • countries should has a table, so we can use country_id in users table, not country (name)
  • for table names, you should use snake_case, like "full_name"
  • nullable and unique, are methods, so you should call them like ->nullable() with brackets at the end
  • you should create a new db migration file, editing existed file will not reflect your edit unless someone start installing from empty db.

Keep it going, you'll have great skills in no time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants