Core reconstruction #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldf and core reconstruction improved and refined.
…econstruction Conflicts: sapphire/simulations/ldf.py
Add size and energy to the return for each core reconstruction algorithm. Store the reconstructed size and energy. Make EllipsLdfAlgorithm default for reconstructing coincidences.
If direction has been reconstructed, pass those values to core reconstruction.
Realign some lines of code for clarification. AverageIntersectionAlgorithm wants at least 4 detections, if less are given it returns nans.
A better ldf (NKG with Greisen modification) is implemented in ldf.py and some comments are added to core_reconstruction.py to clarify different steps in the algorithm. To the latter also a relation between shower size and energy is added for energy reconstruction.
…econstruction Resolved conflicts in: sapphire/analysis/core_reconstruction.py sapphire/simulations/ldf.py
Resolve conflicts in core_reconstruction, reconstructions, and ldf modules. Use memoize for caching of c(s) values. Fix some tests and add placeholder tests for ldf. Improve algorithm readability. Catch more warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More improvements to core reconstructions.