Modernize with new tooling and fix or update some code #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include some manual fixes, e.g. for scripts using Python 2 syntax.
Use more specific exceptions. Use variables for magic numbers used in functions. Use Path instead of os.path. Try not to shadow built in variables/functions. More specific noqa. Remove executable permission for files which do not need it.
Improve handling of some exceptions.
These should be checked in the future.
The addCleanup is usually safer because it is also performed if the rest of the setUp fails. It also keeps the cleanup close to the setup.
Convert strings to f-strings. Remove expectation that pbar is called for tsv update.
… random" Use global random state in numpy instead of separate generators. It will be best to switch to separate generators per class to better control the random state and have independent states.
Correct a call to range_filter using keyword.
153957
changed the title
New version of Numpy includes new features related to type conversion when doing comparisons, uint64 is no longer cast to float64 when compared to ints. Tests are updated to expect this. New numpy version also requires new scipy and tables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply ruff fixes and formatting.
Configure ruff instead of flake8.
Add editorconfig
Replace setup.py by pyproject.toml
Fix/ignore remaining ruff errors
Fix broken tests.
Support Python 3.12
Drop support for Python 3.8
Upgrade some old script to support Python 3
Update required version for dependencies, compatible with Python 3.9-3.12.