-
-
Notifications
You must be signed in to change notification settings - Fork 36
feat(v): add queries #34
base: master
Are you sure you want to change the base?
Conversation
I get an error at the root node of the test file:
|
Hey thanks for taking care if this. Looks like i was sloppy there. I'll check on it asap 👍 Sorry about the inconvenience. |
Main problem I've forgot about is that vim sets the ft for files with a |
Don't worry about that, it's outside the scope of this project. Anyone who uses V will already have adjusted the file type detection, and those who have not don't use V anyway. |
Hey @HiPhish, I updated the test to include code that actually compiles. It's still code that doesn't make a lot of sense. Sorry again about the miss in the initial PR. Can you tell me how you run your tests? I haven't found anything in either the readme or the contribution file. Unfortunately, I have fairly little time to find out by doing my own investigation. Then I would be happy to adapt to further needs 👍 |
I open the test file manually, then I open the Tree-sitter playground and check whether everything looks correct. It's not very efficient, but queries rarely change, so it's not a big deal. Still, it would be good to automate the process, especially for testing strategies. Neovim 0.9 has introduced |
Thanks for you message @HiPhish. Totally fine to do it that way. And now, I know what to look at! But I don't get the parsing errors. Could it be that it's because of a wrong filetype when you entering the .v file? I submitted proper filetype detection the vim just about last week or so. Meanwhile it also made it into vim. Are you using nightly? rb2.mp4 |
You are correct, I had the file type Verilog set, my bad. It would be a good idea to add a little modeline comment at the end of the file to set the file type explicitly when there is any possibility of ambiguity. See Anyway, I have now looked into it and there are a number of node types I don't see in the tree:
Am I missing something again? |
No you are right again @HiPhish. I didn't added all of the node types in the test file. I'll update it in the coming week. |
No description provided.