Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial indieGala support #3532

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Conversation

kohend
Copy link
Contributor

@kohend kohend commented Feb 7, 2024

  • list
  • install
  • launch (only with wine, not proton
  • freecarnival binary for Linux Login needs to be done manually with freecarnival
    no custom settings dir

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

* list
* install
* launch (only with wine, not proton
* freecarnival binary for Linux
Login needs to be done manually with freecarnival
no custom settings dir
@kohend
Copy link
Contributor Author

kohend commented Feb 7, 2024

#1096

@flavioislima
Copy link
Member

flavioislima commented Feb 7, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@kohend
Copy link
Contributor Author

kohend commented Feb 7, 2024

I have read the CLA Document and I hereby sign the CLA

@arielj
Copy link
Collaborator

arielj commented Feb 14, 2024

I'm trying to test this but I can't log in. I get logged in in the store but heroic keeps showing me as not logged in. I don't see any error anywhere that could help, not sure what could be useful for me to try.

@kohend
Copy link
Contributor Author

kohend commented Feb 14, 2024

Are you logging in through the stores nenu? Since I haven't gotten the login to work through the nanage accounts flow. Are you logging in with Google or something?

@arielj
Copy link
Collaborator

arielj commented Feb 14, 2024

Are you logging in through the stores nenu? Since I haven't gotten the login to work through the nanage accounts flow. Are you logging in with Google or something?

right, I understand now the last element listed in the description, I was trying to login using Heroic, but I see it needs to be done using the freecarnival binary in the console

ignore my comment then, it was just me using something not yet implemented

@kohend
Copy link
Contributor Author

kohend commented Feb 14, 2024

image
No, I implemented the login since, but perhaps after you pulled the code? added a screenshot to show where to login from.

@Gustash
Copy link
Contributor

Gustash commented Feb 15, 2024

So, a couple of things on this early stage:

  • The login flow is counter-intuitive to the other stores. You should handle login in Manage Accounts instead. No other stores log you in by using the Stores tab.

  • You are not creating the carnival_config folder, everything breaks if the folder does not exist.

  • Login does not work if there isn't an existing user.yml file in carnival_config. To get that, you should call any FreeCarnival command that syncs the authentication. There isn't a dedicated command right now, but we can add a refresh/sync command. Alternatively, you can just call library, but it seems wasteful to request so much data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants