Help center feature split #2069
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should allow us to keep the Android only dependencies in the -ui module and in the future allow us to keep the -data one clean of any non KMP compatible dependencies This does no changes to the functionality/logic of that feature, only moves things around
…help-center-feature-split # Conflicts: # app/feature/feature-help-center/feature-help-center-ui/build.gradle.kts
Avoids having to know anything about the context in the destination object itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
split into "...-ui" module, to stay as the android module
And into "...-data" module which we can look into moving into a jvm module as a first step.
More modules need to be migrated first for this to be possible, like the gql one, but this is just a step in this process :D
This was branched from develop and I merged help-center-feature into it, which is why it contains more commits as well as what I did here. This will be cleared up when we just merge that feature to develop anyway, or when we just bring develop into it instead. For now don't bother reviewing yet.