Merge branches 'master' and 'master' of github.com:HaschekSolutions/o…

…pentrashmail
HaschekSolutions · Nov 24, 2023 · 4298f1a · 4298f1a
2 parents b200949 + 97f427b
commit 4298f1a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 11 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## V1.2.3
+- Fixed attachment deletion bug
+- Fixed random email generation
+
 ## V1.2.0
  - Implemented IP/Subnet filter using the config option `ALLOWED_IPS`
  - Implemented Password authentication of the site and API using config option `PASSWORD`

diff --git a/web/inc/core.php b/web/inc/core.php
@@ -134,17 +134,12 @@ function attachmentExists($email,$id,$attachment=false)
 
 function listAttachmentsOfMailID($email,$id)
 {
-    $o = array();
-    if ($handle = opendir(getDirForEmail($email).DS.'attachments')) {
-        while (false !== ($entry = readdir($handle))) {
-            if (startsWith($entry,$id.'-')) {
-                $o[] = $entry;
-            }
-        }
-        closedir($handle);
-    }
-
-    return $o;
+    $data = json_decode(file_get_contents(getDirForEmail($email).DS.$id.'.json'),true);
+    $attachments = $data['parsed']['attachments'];
+    if(!is_array($attachments))
+        return [];
+    else
+        return $attachments;
 }
 
 function deleteEmail($email,$id)