Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dummy change #34

Closed
wants to merge 5 commits into from
Closed

Dummy change #34

wants to merge 5 commits into from

Conversation

HannesWell
Copy link
Owner

No description provided.

Copy link

⚠️ Failed to request review of not vetted licenses.

Workflow run (with attached summary files):
https://github.com/HannesWell/dash-licenses/actions/runs/8316446740

Copy link

⚠️ Failed to request review of not vetted licenses.

Workflow run (with attached summary files):
https://github.com/HannesWell/dash-licenses/actions/runs/8316472840

Copy link

⚠️ Failed to request review of not vetted licenses.

Workflow run (with attached summary files):
https://github.com/HannesWell/dash-licenses/actions/runs/8316500089

Copy link

⚠️ Failed to request review of not vetted licenses.

Workflow run (with attached summary files):
https://github.com/HannesWell/dash-licenses/actions/runs/8316510575

Copy link

⚠️ Failed to request review of not vetted licenses.

Workflow run (with attached summary files):
https://github.com/HannesWell/dash-licenses/actions/runs/8316555311

Since eclipse#220 license-reviews
are automatically requested for PRs created by dependabot. But in that
change the logic of the 'Process license check results' step was not
updated to consider that case. This had the effect that the
license-vetting workflow always succeeded for PRs created by dependabot.

The intention to not fail the workflow in general when a license-review
was requested is because initially review-request were only created
manually from committers by adding a corresponding comment to the PR.
And that workflow execution should not fail respectively its result was
actually irrelevant.

Fixes eclipse-tycho/tycho#3661
Copy link

⚠️ Failed to request review of not vetted licenses.

Workflow run (with attached summary files):
https://github.com/HannesWell/dash-licenses/actions/runs/8316572625

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant