Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libhb: remove hb_scan, as directed by TODO #6032

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

samhutchins
Copy link
Contributor

Description of Change:

hb_scan is basically a wrapper around hb_scan_list, wrapping the path passed to it in a single-item list. There's a TODO left in there about removing it when all the UIs are updated.

The only 2 places it's still used (as far as I can tell) are by the CLI and by hb_json_job_scan. I've updated both places to use hb_scan_list instead.

I'm not actually sure if this is a good change or not, as it makes the call-sites a little messier. But it does make it easier to change the signature of hb_scan.

I think that removing the TODO comment is also a valid course of action, I don't think it's that bad having both hb_scan methods personally

Tested on:

  • Windows 10+ (via MinGW)
  • macOS 10.13+
  • Fedora Linux

@galad87
Copy link
Contributor

galad87 commented May 22, 2024

Maybe hb_scan_list can be renamed back to hb_scan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants