libhb: remove hb_scan, as directed by TODO #6032
Open
+18
−35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change:
hb_scan
is basically a wrapper aroundhb_scan_list
, wrapping the path passed to it in a single-item list. There's a TODO left in there about removing it when all the UIs are updated.The only 2 places it's still used (as far as I can tell) are by the CLI and by
hb_json_job_scan
. I've updated both places to usehb_scan_list
instead.I'm not actually sure if this is a good change or not, as it makes the call-sites a little messier. But it does make it easier to change the signature of
hb_scan
.I think that removing the TODO comment is also a valid course of action, I don't think it's that bad having both
hb_scan
methods personallyTested on: