-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sub Overhaul Prototype #5736
Open
sr55
wants to merge
9
commits into
HandBrake:master
Choose a base branch
from
sr55:SubOverhaul
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Sub Overhaul Prototype #5736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The base functionality / UX is now all in place. Feedback welcome. |
Open
…iours (SRT,SSA and ASS)
Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New Subtitle Rules Panel (#1860)
This provides a more flexible set of options for automatically adding subtitle tracks when importing a source into HandBrake.
Would appreciate some feedback on the UX of the new panel design.
I may add wildcard support in the subtitle name field in another PR, for now I'm focusing on the core functionality .
I've dropped the Add CC when available option. it seems redundant.
Preset Format Changes:
The new preset format is as follows:
We can probably migrate the format forward to a limited degree when the mac and linux Ui's update as well.
Screenshots (If relevant):