Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sub Overhaul Prototype #5736

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Sub Overhaul Prototype #5736

wants to merge 9 commits into from

Conversation

sr55
Copy link
Contributor

@sr55 sr55 commented Jan 30, 2024

Description

New Subtitle Rules Panel (#1860)

This provides a more flexible set of options for automatically adding subtitle tracks when importing a source into HandBrake.

Would appreciate some feedback on the UX of the new panel design.

I may add wildcard support in the subtitle name field in another PR, for now I'm focusing on the core functionality .

I've dropped the Add CC when available option. it seems redundant.

Preset Format Changes:

The new preset format is as follows:

We can probably migrate the format forward to a limited degree when the mac and linux Ui's update as well.

        "SubtitleBehaviours": [
            {
              "IsoLangCode": "eng",
              "TrackSelectionMode": 0,
              "DefaultMode": 0,
              "BurnPassthruMode": 0,
              "ForcedMode": 0,
              "TrackNameOverride": "Test",
              "IsForeignAudioScanRule": 1
            },
            {
              "IsoLangCode": "fra",
              "TrackSelectionMode": 1,
              "DefaultMode": 1,
              "BurnPassthruMode": 1,
              "ForcedMode": 0,
              "TrackNameOverride": "Test 2",
              "IsForeignAudioScanRule": 0
            },
            {
              "IsoLangCode": "deu",
              "TrackSelectionMode": 0,
              "DefaultMode": 0,
              "BurnPassthruMode": 2,
              "ForcedMode": 0,
              "TrackNameOverride": "Test 3",
              "IsForeignAudioScanRule": 0
            }
          ],
          "SubtitleUseSourceOrder": true,
          "SubtitleAutoloadExternal": true,
          "SubtitlePassthruTrackNames": true,
Field Type Values
IsoLangCode string Iso639 code or "foreign"
TrackSelectionMode Int 0 = First Match, 1 = All Matching
DefaultMode Int 0 = No, 1 = Yes
BurnPassthruMode Int 0 = PassthruDrop, 1= PassthruBurnDrop, 2= BurnDrop
ForcedMode Int 0 = No, 1 = Yes
IsForeignAudioScanRule Int 0 = No, 1 = Yes

Screenshots (If relevant):

image

@sr55 sr55 added this to the 1.8.0 milestone Jan 30, 2024
@sr55 sr55 changed the title Sub overhaul Sub Overhaul Prototype Jan 30, 2024
@sr55
Copy link
Contributor Author

sr55 commented Feb 23, 2024

The base functionality / UX is now all in place. Feedback welcome.

@sr55 sr55 modified the milestones: 1.8.0, 1.9.0 Apr 19, 2024
@sr55 sr55 mentioned this pull request May 23, 2024
@sr55
Copy link
Contributor Author

sr55 commented May 27, 2024

Rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

1 participant