Channels, Commands: Part, Join, and Channel #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add channel name and validation Add join and part channels
Add channels to server struct
…th the output channel
Add RemoveUserFromChannel
Add Channels command with users subcommand for listing all users in a channel
| // IsValidChannelName checks the length and format of a string and returns | ||
| // true if the string is valid | ||
| func IsValidChannelName(name string) bool { | ||
| if len(name) < 50 && ValidChannelNameRgx.MatchString(name) { |
There was a problem hiding this comment.
Will
len(name) < 50 && ValidChannelNameRgx.MatchString(name)evaluate to a boolean? If it will, I would simply return the result of that instead of using the conditional here to return the true/false
There was a problem hiding this comment.
Yeah, I should have noticed that. The change will be in my next push.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Channel command and subcommand "users". Closes issues #4, #17 and #18
Add Join and Part commands. Closes issues #5 and #6