Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding config-style definitions for ion species properties #109

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

psktam
Copy link
Collaborator

@psktam psktam commented Mar 18, 2023

Summary:

  • Adding config files for ion properties rather than defining them in code
  • Removed the interstitial IonInstance class. We now directly instantiate Ion
  • Moved IonProperties and config file functions to their own file, as it felt like ions.jl was getting too big.

@psktam
Copy link
Collaborator Author

psktam commented Mar 18, 2023

Ah sorry @marwahaha ; didn't mean to tag you as a reviewer; it was a fat-finger, and it doesn't seem like I can remove you. Feel free to review or not review as you please.

@codecov
Copy link

codecov bot commented Mar 18, 2023

Codecov Report

Patch coverage: 94.0% and project coverage change: +5.4 🎉

Comparison is base (3bbdce9) 83.5% compared to head (2861498) 88.8%.

❗ Current head 2861498 differs from pull request most recent head 4892a28. Consider uploading reports for the commit 4892a28 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #109     +/-   ##
========================================
+ Coverage    83.5%   88.8%   +5.4%     
========================================
  Files          15      13      -2     
  Lines        1488    1270    -218     
========================================
- Hits         1242    1128    -114     
+ Misses        246     142    -104     
Impacted Files Coverage Δ
src/IonSim.jl 100.0% <ø> (ø)
src/ions.jl 87.8% <84.6%> (+1.5%) ⬆️
src/ionproperties.jl 97.3% <97.3%> (ø)

... and 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@psktam psktam linked an issue Mar 18, 2023 that may be closed by this pull request
@neil-glikin
Copy link
Collaborator

Have some convenient shorthand for loadfromconfig("../configs/ions/[ionname].yaml") to be able to easily load properties of predefined ion species

@jbroz11
Copy link
Member

jbroz11 commented Mar 25, 2023

Have some convenient shorthand for loadfromconfig("../configs/ions/[ionname].yaml") to be able to easily load properties of predefined ion species

I think this is ready to merge once this is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define Configuration Schema for Ion Species
3 participants