Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code to use response.json() instead of response.text() in Jo… #32

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SpartanDeBoss
Copy link
Collaborator

…inRetroPage.jsx

Description

Please provide a short summary explaining what this PR is about.

Fixes # (issue)

How to test?

Please provide a short summary how your changes can be tested?

Checklist

  • I have performed a self-review of my own code
  • I have followed the name conventions for CSS Classnames and filenames, Components names and filenames, Style filenames, if you are in doubt check the the project README.MD and here https://github.com/HackYourFuture-CPH/curriculum/blob/master/review/review-checklist.md
  • I have commented my code, particularly in hard-to-understand areas, if you code was simple enough mark the box anyway
  • I have made corresponding changes to the documentation, if you code was simple enough mark the box anyway
  • This PR is ready to be merged and not breaking any other functionality

@SpartanDeBoss SpartanDeBoss requested a review from a team as a code owner April 22, 2024 18:29
@SpartanDeBoss
Copy link
Collaborator Author

Hello @orhantoy,
About yesterday you mentioned that I could "push it". I wanted to follow up with you regarding the changes you made. It seems that it's not necessary to generate a code as any characters can get you to the next page. Could you please take a look at it for us? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants