react2-week1/katayoun #294
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aina21
reviewed
Apr 16, 2024
| <input | ||
| type="text" | ||
| placeholder="insert user" | ||
| style={{ |
There was a problem hiding this comment.
Try to avoid using inline styles when possible. Instead, consider moving the styles to a CSS file.
There was a problem hiding this comment.
@aina21
Could you please tell me why I can't see the search results? I get no error. I tried to see what I would get in fetch using console.log(data), and then I could see the items. Therefore I used data. items. However, I would get no search results in the browser. Could you please help me where the problem is? Thank you so much.
aina21
reviewed
Apr 16, 2024
| function UserSearchResult() { | ||
| const { query, loading, error, searchResult } = useContext(userContext); | ||
|
|
||
| return ( |
There was a problem hiding this comment.
Consider simplifying the conditional logic. You could use a helper function or separate the outputs using if conditions, like so:
if (loading) return <div className="loading">Loading...</div>;
aina21
approved these changes
Apr 16, 2024
…ion.jsx + installing and using useDebounce + making key correction <li key={result.id}>{result.login}</li>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.