react1-week3/yousseftopaji #283
Conversation
…e-CPH/class27-homework into react1-week3/yousseftopaji
github-actions
bot
changed the title
There was a problem hiding this comment.
Well done @yousseftopaji 👏 I left few comments, but overall very good.
Just next time please push only the relevant parts of code, so it's clear what is a part of the assignment and whats not. :) Thank you
|
|
||
| const handleUpdate = () => { | ||
| if (newDescription.trim()) { | ||
| if (todo.deadline && new Date(todo.deadline) < new Date()) { |
There was a problem hiding this comment.
I do not think it is necessary to check the deadline if you want to change just the description and not the deadline itself, also right now if you try to edit an element with the deadline in past, there is no other choice than delete the element otherwise you got stuck
There was a problem hiding this comment.
Also I think you were supposed to update all todo's props deadline included
| const [deadline, setDeadline] = useState(null); | ||
|
|
||
| useEffect(() => { | ||
| fetch( |
There was a problem hiding this comment.
although not an issue it's not a good practice to have an anonymous function inside of the useEffect hook
you can assign the fetch logic to a variable (e.g fetchAndSetTodos) and call it afterward inside of the hooks :)
| <h1>Todo List</h1> | ||
| {todos.length === 0 ? ( | ||
| <> | ||
| {" "} |
No description provided.