Correcting Relation IDs and Overwriting Tag IDs #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the IDs in the relations were being parsed and delta decoded. I've removed the cumsum and just used the IDs as they are. These seem to match with OSM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains fixes for #170 and #233 - fixing relation IDs and IDs in tags that overwrite the proper OSM ID.
Addressing #170 first, I found that the IDs from the relations did not need to be delta decoded with the
np.cumsumfunction -they already match the OSM ID for the relation. The example given in #170 now yields the expected result (and an extra three parks that have been added since the issue was made in 2022).
#233 feels more like a patch to me, but it prevents IDs placed into the tags of buildings overwriting the actual ID from OSM.