Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an iframes custom metric #93

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adamsilverstein
Copy link
Contributor

Based on the images metric, this one enumerates iframes present on the page including their:

  • url
  • width & height
  • naturalWidth and naturalHeight (for example when when w/h altered by CSS)
  • inViewport

@tunetheweb
Copy link
Member

Most of this already exists in the almanac custom metric:
https://github.com/HTTPArchive/custom-metrics/blob/main/metric-summary.md#iframes

We should enhance that. Though maybe there’s a good argument to move it to its own file while doing that. WDYT @rviscomi ?

@rviscomi
Copy link
Member

I'd like to move more towards grouping custom metrics by chapter, ie markup.js for things like this.

@tunetheweb
Copy link
Member

Reminder @adamsilverstein . Wanna update the almanac one short term? Or take on the moving of this to markup.js at the same time as doing your updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants