FHIR-40567 renaming MolSeq.formatted to MolSeq.file #3061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on FHIR-40567 and Clinical Genomics IM discussion, it was decided to rename MolSeq.formmated to MolSeq.file.
sirkyp
reviewed
Apr 8, 2024
There was a problem hiding this comment.
@khalifa-aly - did we have examples that use this attribute and also need to be changed?
|
@khalifa-aly - I think we have documentation that references the attribute name as well? |
updating the example to reflect the new name of MolSeq.file instead of MolecularSequence.formatted
updating the introduction section to reflect the new name of MolSeq.file instead of MolecularSequence.formatted
updating the notes section to reflect the new name of MolSeq.file instead of MolecularSequence.formatted
|
I made changes to the documentation, and only one example has MolSeq.file, and changed it. I'll check the build one more time. |
|
@sirkyp thanks for highlighting this. Would you please check the new edits? |
|
Looks good to me @khalifa-aly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on FHIR-40567 and Clinical Genomics IM discussion, it was decided to rename MolSeq.formmated to MolSeq.file.
HL7 FHIR Pull Request
Note: No pull requests will be accepted against
./sourceunless logged in the HL7 Jira issue tracker.If you made changes to any files within
./sourceplease indicate the Jira tracker number this pull request is associated with:Description
Based on FHIR-40567, MolSeq.formatted element was renamed to MolSeq.file.