Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cg im molseq work in progress 2 #2963

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

khalifa-aly
Copy link
Contributor

HL7 FHIR Pull Request

Note: No pull requests will be accepted against ./source unless logged in the HL7 Jira issue tracker.

If you made changes to any files within ./source please indicate the Jira tracker number this pull request is associated with:

Description

Updating Molecular Sequence resource to be definitional and how it represent sequences using various approaches.

Copy link
Contributor

@lmckenzi lmckenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like compartments.xml didn't get normalized before being committed? (Or it could be it wasn't normalized by whoever committed before you...) Can you run a local build and see if that file changes, and if so, commit it to the branch?

@khalifa-aly
Copy link
Contributor Author

khalifa-aly commented Oct 9, 2023

I ran a local build, compartment.xml has not changed, and I got the build errors, below:
ERROR @ MolecularSequence: Resource MolecularSequence in compartment patient: parameter subject was not found (subject) (src = ResourceValidator)
ERROR @ compartment.patient.MolecularSequence.subject: Search Parameter 'subject' not found (src = ResourceValidator)

I commented out the subject cell from the relevant MolecularSequence row, re-ran the build and I got a successful build.
I commented this change and the Azure pipeline ran successfully.

@lmckenzi
Copy link
Contributor

There's now a commented row in compartments.xml. compartments.xml is a spreadsheet, so it shouldn't have comments...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants