simplified grad_dist2 fixing #22 #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compilation attempts led to crashes of python on my machine. Instead of just out-commenting the trial as in #22 I propose this simpler implementation. Equivalence "proof" and run time comparisons can be found at [this gist](https://gist.github.com/jan-glx/e39f2b0ef23b10ee7e13). Please test again against a working c compilation. I have no Idea about what the function is doing, but the way the scaling by ls was implemented is odd, so please check if the square is correct. This is my first pull request ever pleas let me know if I could have done anything better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compilation attempts led to crashes of python on my machine. Instead of just out-commenting the trial as in #22 I propose this simpler implementation. Equivalence "proof" and run time comparisons can be found at this gist. Please test again against a working c compilation. I have no Idea about what the function is doing, but the way the scaling by ls was implemented is odd, so please check if the square is correct.
This is my first pull request ever please let me know if I could have done anything better.